Release 1.5.16

src/web/routes/admin/rbac.js

@@ -147,7 +147,6 @@ module.exports = function registerAdminRbacRoutes(app, deps) {
 		const permissionRows = await rbacData.fetchPermissions(pool);
 		const selectedPermissionKeys = await rbacData.fetchRolePermissionKeys(pool, role.id);
 		const selectedUserIds = await rbacData.fetchRoleUserIds(pool, role.id);
-		const users = await rbacData.fetchUsersWithRoles(pool);
 		return {
 			role: Object.assign({}, role, {
 				permissionKeys: selectedPermissionKeys,
@@ -155,7 +154,7 @@ module.exports = function registerAdminRbacRoutes(app, deps) {
 				userCount: Number(role.user_count) || 0
 			}),
 			permissionGroups: buildPermissionGroups(mapPermissionsForView(permissionRows, selectedPermissionKeys)),
-			users: mapUsersForView(users, selectedUserIds)
+			selectedUserIds: selectedUserIds
 		};
 	}
 
@@ -251,14 +250,17 @@ module.exports = function registerAdminRbacRoutes(app, deps) {
 				return res.status(404).send('Role not found.');
 			}
 
+			const page = Math.max(1, Math.floor(Number(req.query.page) || 1));
+			const search = common.getSearchQuery(req);
+			const sort = common.getSortQuery(req);
+			const direction = common.getSortDirectionQuery(req);
 			const currentUserId = req.currentUser ? Number(req.currentUser.id) : null;
-			const users = Array.isArray(viewModel.users)
-				? viewModel.users.filter(function (user) {
-					return Number(user && user.id) !== currentUserId;
-				})
-				: [];
+			const data = await rbacData.fetchUsersWithRolesPage(pool, page, LIST_PAGE_SIZE, search, sort, direction, {
+				excludeUserId: currentUserId
+			});
+			const users = mapUsersForView(data.users, viewModel.selectedUserIds);
 
-			res.send(pages.renderRbacEditPage(viewModel.role, req.query.message ? String(req.query.message) : '', req.currentUser, viewModel.permissionGroups, users));
+			res.send(pages.renderRbacEditPage(viewModel.role, req.query.message ? String(req.query.message) : '', req.currentUser, viewModel.permissionGroups, users, buildPagination(data.totalItems, data.currentPage, 'page', { search: search, sort: sort, direction: direction }, LIST_PAGE_SIZE, 'users', 'User pages')));
 		} catch (error) {
 			next(error);
 		}