Release v2.10.4

test/web-screens-routes.test.js

@@ -6,7 +6,7 @@ require('../src/common');
 const registerScreensRoutes = require('../src/web/routes/signage/screens/routes');
 const { renderScreenEditPage } = require('../src/web/pages');
 
-test('screen edit page includes shared launcher downloads and base player url', async () => {
+test('screen edit page omits player URL data', async () => {
   const handlers = {};
   const app = {
     get(path, ...routeHandlers) {
@@ -88,25 +88,11 @@ test('screen edit page includes shared launcher downloads and base player url',
   await handler[1]({ params: { id: '7' }, query: {}, currentUser: { id: 1 } }, res, () => {});
 
   assert.equal(res.body, 'ok');
-  assert.deepEqual(renderedArgs.screen.player_urls, [
-    {
-      identifier: 'player-alpha',
-      public_base_url: 'http://alpha.example',
-      player_url: 'http://alpha.example/screen/demo-conference'
-    },
-    {
-      identifier: 'player-beta',
-      public_base_url: 'http://beta.example',
-      player_url: 'http://beta.example/screen/demo-conference'
-    }
-  ]);
-  assert.deepEqual(renderedArgs.screen.launcher_downloads, {
-    windows: '/downloads/kiosk/pulse-signage-kiosk.bat',
-    linux: '/downloads/kiosk/pulse-signage-kiosk.sh'
-  });
+  assert.equal(Object.prototype.hasOwnProperty.call(renderedArgs.screen, 'player_urls'), false);
+  assert.equal(Object.prototype.hasOwnProperty.call(renderedArgs.screen, 'launcher_downloads'), false);
 });
 
-test('screen edit query route includes player urls for every registration', async () => {
+test('screen edit query route omits player URLs', async () => {
   const handlers = {};
   const app = {
     get(path, ...routeHandlers) {
@@ -172,20 +158,11 @@ test('screen edit query route includes player urls for every registration', asyn
   await handler[1]({ query: { edit: '7' }, currentUser: { id: 1 } }, res, () => {});
 
   assert.equal(res.body, 'ok');
-  assert.deepEqual(renderedArgs.screen.player_urls, [
-    {
-      identifier: 'player-alpha',
-      public_base_url: 'http://alpha.example',
-      player_url: 'http://alpha.example/screen/demo-conference'
-    }
-  ]);
-  assert.deepEqual(renderedArgs.screen.launcher_downloads, {
-    windows: '/downloads/kiosk/pulse-signage-kiosk.bat',
-    linux: '/downloads/kiosk/pulse-signage-kiosk.sh'
-  });
+  assert.equal(Object.prototype.hasOwnProperty.call(renderedArgs.screen, 'player_urls'), false);
+  assert.equal(Object.prototype.hasOwnProperty.call(renderedArgs.screen, 'launcher_downloads'), false);
 });
 
-test('screen edit page hides stale player registrations', async () => {
+test('screen edit page does not load player URL registrations', async () => {
   const handlers = {};
   const app = {
     get(path, ...routeHandlers) {
@@ -258,22 +235,10 @@ test('screen edit page hides stale player registrations', async () => {
   await handler[1]({ params: { id: '7' }, query: {}, currentUser: { id: 1 } }, res, () => {});
 
   assert.equal(res.body, 'ok');
-  assert.deepEqual(renderedArgs.screen.player_urls.map(function (player) {
-    return {
-      identifier: player.identifier,
-      public_base_url: player.public_base_url,
-      player_url: player.player_url
-    };
-  }), [
-    {
-      identifier: 'player-recent',
-      public_base_url: 'http://recent.example',
-      player_url: 'http://recent.example/screen/demo-conference'
-    }
-  ]);
+  assert.equal(Object.prototype.hasOwnProperty.call(renderedArgs.screen, 'player_urls'), false);
 });
 
-test('screen edit page renders player urls as an adminlte table', async () => {
+test('screen edit page does not render a player URL table', async () => {
   const html = renderScreenEditPage(
     {
       id: 7,
@@ -282,24 +247,14 @@ test('screen edit page renders player urls as an adminlte table', async () => {
       playlist_id: null,
       slug_update_confirm_live_connection_count: 2,
       slug_update_confirm_message: 'Are you sure you want to update the slug? This will refresh all screens using this slug.',
-      player_urls: [
-        {
-          identifier: 'player-alpha',
-          public_base_url: 'http://alpha.example',
-          player_url: 'http://alpha.example/screen/demo-conference'
-        }
-      ]
     },
     { playlists: [] },
     '',
     { id: 1 }
   );
 
-  assert.match(html, /Player URLs/);
-  assert.match(html, /<table/i);
-  assert.match(html, /card-body table-responsive p-0/);
-  assert.match(html, /table table-striped w-100 mb-0/);
-  assert.match(html, /player-alpha/);
+  assert.doesNotMatch(html, /Player URLs/);
+  assert.doesNotMatch(html, /player-alpha/);
   assert.match(html, /<input[^>]+id="screen-slug"[^>]+disabled/);
   assert.match(html, /Slug cannot be changed after creation/);
 });