From ac18644fe848bb1332c4b399aefb40a7ca04c6ef Mon Sep 17 00:00:00 2001 From: Mark Rapson Date: Sun, 13 Sep 2026 23:47:11 +0100 Subject: [PATCH] Release 2.13.3 --- CHANGELOG.md | 7 +++++++ build/package.player.json | 2 +- build/package.web.json | 2 +- package-lock.json | 4 ++-- package.json | 2 +- src/web/public/js/media-picker.js | 9 ++++++++- src/web/public/js/templates/template-designer.js | 2 +- .../views/signage/templates/animation-advanced-modal.hbs | 1 - src/web/views/signage/templates/form.hbs | 2 +- test/templates.test.js | 3 +++ 10 files changed, 25 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a8f0f93..1481531 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to this project will be documented in this file. +## 2.13.3 - 2026-09-13 + +### Fixed + +- Fixed the template background image media picker Upload media button so it opens the file selector. +- Fixed the template designer empty background message moving when the background image is removed. + ## 2.13.2 - 2026-09-11 ### Changed diff --git a/build/package.player.json b/build/package.player.json index cc0a2db..c3d5beb 100644 --- a/build/package.player.json +++ b/build/package.player.json @@ -1,6 +1,6 @@ { "name": "pulse-signage-player", - "version": "2.13.2", + "version": "2.13.3", "private": false, "description": "Pulse Signage player application bundle", "engines": { diff --git a/build/package.web.json b/build/package.web.json index 8ba7a77..f3b1fde 100644 --- a/build/package.web.json +++ b/build/package.web.json @@ -1,6 +1,6 @@ { "name": "pulse-signage-web", - "version": "2.13.2", + "version": "2.13.3", "private": false, "description": "Pulse Signage web and bridge application bundle", "engines": { diff --git a/package-lock.json b/package-lock.json index d35e4be..c2305ba 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "pulse-signage", - "version": "2.13.2", + "version": "2.13.3", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "pulse-signage", - "version": "2.13.2", + "version": "2.13.3", "dependencies": { "@sparticuz/chromium": "^149.0.0", "animate.css": "^4.1.1", diff --git a/package.json b/package.json index a7ecdfb..e414858 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "pulse-signage", - "version": "2.13.2", + "version": "2.13.3", "private": false, "description": "Pulse Signage application with MySQL and media storage", "engines": { diff --git a/src/web/public/js/media-picker.js b/src/web/public/js/media-picker.js index 78aee56..a6fc79c 100644 --- a/src/web/public/js/media-picker.js +++ b/src/web/public/js/media-picker.js @@ -160,9 +160,16 @@ if (!activeButton) { return null; } + var explicitInputId = activeButton.getAttribute('data-media-picker-file-input'); + if (explicitInputId) { + var explicitInput = document.getElementById(explicitInputId); + if (explicitInput) { + return explicitInput; + } + } var hiddenKey = activeButton.getAttribute('data-media-picker-hidden'); if (hiddenKey) { - var inputFromHidden = document.getElementById(hiddenKey.replace(/^existing_/, '')); + var inputFromHidden = document.getElementById(hiddenKey.replace(/^existing[-_]/, '')); if (inputFromHidden) { return inputFromHidden; } diff --git a/src/web/public/js/templates/template-designer.js b/src/web/public/js/templates/template-designer.js index 234a8c8..357b7fd 100644 --- a/src/web/public/js/templates/template-designer.js +++ b/src/web/public/js/templates/template-designer.js @@ -1797,7 +1797,7 @@ } backgroundPreview.removeAttribute('src'); backgroundPreview.style.display = 'none'; - backgroundEmpty.style.display = 'block'; + backgroundEmpty.style.display = 'flex'; }); } if (animationAdvancedModal) { diff --git a/src/web/views/signage/templates/animation-advanced-modal.hbs b/src/web/views/signage/templates/animation-advanced-modal.hbs index 3c21d5c..972c8cf 100644 --- a/src/web/views/signage/templates/animation-advanced-modal.hbs +++ b/src/web/views/signage/templates/animation-advanced-modal.hbs @@ -7,7 +7,6 @@
-
Changes here are saved into the region animation JSON and stay in sync with the preset dropdowns.
diff --git a/src/web/views/signage/templates/form.hbs b/src/web/views/signage/templates/form.hbs index 62b1812..b5e394d 100644 --- a/src/web/views/signage/templates/form.hbs +++ b/src/web/views/signage/templates/form.hbs @@ -103,7 +103,7 @@
- +
diff --git a/test/templates.test.js b/test/templates.test.js index 5b4ccc4..4c6c4db 100644 --- a/test/templates.test.js +++ b/test/templates.test.js @@ -155,6 +155,9 @@ test('template create page renders the background remove control', () => { assert.match(html, /id="remove-background-image"/); assert.match(html, /name="remove_background_image"/); + assert.match(html, /data-media-picker-hidden="existing-background-image-path"/); + assert.match(html, /data-media-picker-file-input="background-image"/); + assert.match(html, /id="background-image"/); assert.match(html, /placeholder="type_1"/); assert.match(html, /Save and Close/); assert.match(html, /Save and New/);