Release v2.17.0: add read-only user previews and access fallbacks

test/timetable-migrations.test.js

@@ -3,7 +3,7 @@ const assert = require('node:assert/strict');
 
 require('../src/common');
 
-const { runMigrations } = require('../src/db/migrations');
+const { getPendingMigrations, runMigrations } = require('../src/db/migrations');
 
 function createPool(responses) {
   const queries = [];
@@ -142,4 +142,32 @@ test('timetable timezone migrations use timetable tables when legacy tables are
   assert.ok(!pool.queries.some(function ([sql]) {
     return String(sql).includes('i_schedule_groups') || String(sql).includes('i_schedule_entries');
   }));
+});
+
+test('2.17.0 migration adds the expiring view-as session columns', async () => {
+  const pool = createPool([
+    {
+      match(sql) {
+        return sql.includes('FROM information_schema.COLUMNS');
+      },
+      result: [[{ column_count: 0 }]]
+    },
+    {
+      match(sql) {
+        return sql.includes('FROM information_schema.TABLES');
+      },
+      result: [[{ table_count: 0 }]]
+    }
+  ]);
+
+  const pending = await getPendingMigrations(pool, { currentVersion: '2.16.2' });
+  assert.deepEqual(pending.map(function (migration) { return migration.version; }), ['2.17.0']);
+  await pending[0].run(pool);
+
+  assert.ok(pool.queries.some(function ([sql]) {
+    return String(sql).includes('ALTER TABLE a_sessions ADD COLUMN view_as_user_id INT NULL AFTER user_id');
+  }));
+  assert.ok(pool.queries.some(function ([sql]) {
+    return String(sql).includes('ALTER TABLE a_sessions ADD COLUMN view_as_expires_at DATETIME NULL AFTER view_as_user_id');
+  }));
 });