Release 2.6.7

test/player-bridge-web-base-url.test.js

@@ -3,19 +3,19 @@ const assert = require('node:assert/strict');
 
 require('../src/common');
 
-const originalWebBaseUrl = process.env.WEB_BASE_URL;
-const { resolveWebBaseUrl, resolveScreenCommandTargets } = require('../src/player-bridge/index');
+const originalWebBaseUrl = process.env.WEB_INTERNAL_URL;
+const { resolveWebBaseUrl, resolveScreenCommandTargets, resolveSnapshotUpstreamBaseUrl } = require('../src/player-bridge/index');
 
 test.after(() => {
   if (originalWebBaseUrl === undefined) {
-    delete process.env.WEB_BASE_URL;
+    delete process.env.WEB_INTERNAL_URL;
   } else {
-    process.env.WEB_BASE_URL = originalWebBaseUrl;
+    process.env.WEB_INTERNAL_URL = originalWebBaseUrl;
   }
 });
 
-test('resolveWebBaseUrl prefers WEB_BASE_URL', () => {
-  process.env.WEB_BASE_URL = 'https://web.example.test/app/';
+test('resolveWebBaseUrl prefers WEB_INTERNAL_URL', () => {
+  process.env.WEB_INTERNAL_URL = 'https://web.example.test/app/';
 
   const resolved = resolveWebBaseUrl({
     headers: {
@@ -30,7 +30,7 @@ test('resolveWebBaseUrl prefers WEB_BASE_URL', () => {
 });
 
 test('resolveWebBaseUrl keeps external https hosts on the default port', () => {
-  delete process.env.WEB_BASE_URL;
+  delete process.env.WEB_INTERNAL_URL;
 
   const resolved = resolveWebBaseUrl({
     headers: {
@@ -60,4 +60,31 @@ test('resolveScreenCommandTargets only returns open sockets for the requested sc
   assert.deepEqual(targets.map(function (target) {
     return target.deviceId;
   }), ['player-a']);
+});
+
+test('resolveScreenCommandTargets falls back to a single open socket when the screen map is empty', () => {
+  const playerSockets = new Map([
+    ['player-a', { readyState: 1, playerDeviceId: 'player-a' }]
+  ]);
+  const screenPlayerDeviceIds = new Map();
+
+  const targets = resolveScreenCommandTargets('demo-conference', playerSockets, screenPlayerDeviceIds);
+
+  assert.deepEqual(targets.map(function (target) {
+    return target.deviceId;
+  }), ['player-a']);
+});
+
+test('resolveSnapshotUpstreamBaseUrl prefers a local internal player url', () => {
+  assert.equal(resolveSnapshotUpstreamBaseUrl({
+    public_base_url: 'https://pulse-dev-player.lzstealth.com',
+    internal_base_url: 'http://player-dev:8081'
+  }), 'http://player-dev:8081');
+});
+
+test('resolveSnapshotUpstreamBaseUrl falls back to the public player url for remote players', () => {
+  assert.equal(resolveSnapshotUpstreamBaseUrl({
+    public_base_url: 'https://remote-player.example',
+    internal_base_url: 'https://pulse-dev-bridge.lzstealth.com'
+  }), 'https://remote-player.example');
 });