Release 2.6.7

src/web/lib/background-tasks/tasks-scheduled/font-sweep.js

@@ -18,57 +18,50 @@ function registerFontSweepTask(options) {
   const uploadSyncService = options && options.uploadSyncService;
   const pushUploadFileToPlayer = uploadSyncService && uploadSyncService.pushUploadFileToPlayer;
   const removeUploadFileFromPlayer = uploadSyncService && uploadSyncService.removeUploadFileFromPlayer;
-  const getPlayerTaskMetadata = uploadSyncService && uploadSyncService.getPlayerTaskMetadata;
   const mediaDir = String(options && options.mediaDir || '').trim();
 
   if (!backgroundTaskQueue || typeof pushUploadFileToPlayer !== 'function' || typeof removeUploadFileFromPlayer !== 'function' || !mediaDir) {
     throw new Error('registerFontSweepTask requires the font sweep dependencies.');
   }
 
-  const metadataPromise = typeof getPlayerTaskMetadata === 'function'
-    ? Promise.resolve(getPlayerTaskMetadata())
-    : Promise.resolve({});
+  backgroundTaskQueue.registerRecurringTask({
+    key: TASK.key,
+    title: TASK.title,
+    category: TASK.category,
+    intervalMs: TASK.intervalMs,
+    metadata: {
+      mediaDir: mediaDir
+    },
+    run: async function () {
+      const desiredOperations = collectFontLibrarySyncOperations(mediaDir);
+      const desiredUploadPaths = new Set(desiredOperations.map(function (operation) {
+        return operation && operation.uploadPath ? operation.uploadPath : '';
+      }).filter(Boolean));
+      const currentUploadPaths = await collectFontLibraryDirectoryUploadPaths(mediaDir);
 
-  return metadataPromise.then(function (metadata) {
-    backgroundTaskQueue.registerRecurringTask({
-      key: TASK.key,
-      title: TASK.title,
-      category: TASK.category,
-      intervalMs: TASK.intervalMs,
-      metadata: Object.assign({
-        mediaDir: mediaDir
-      }, metadata || {}),
-      run: async function () {
-        const desiredOperations = collectFontLibrarySyncOperations(mediaDir);
-        const desiredUploadPaths = new Set(desiredOperations.map(function (operation) {
-          return operation && operation.uploadPath ? operation.uploadPath : '';
-        }).filter(Boolean));
-        const currentUploadPaths = await collectFontLibraryDirectoryUploadPaths(mediaDir);
-
-        for (let i = 0; i < desiredOperations.length; i += 1) {
-          const operation = desiredOperations[i] || {};
-          const uploadPath = String(operation.uploadPath || '').trim();
-          if (!uploadPath) {
-            continue;
-          }
-
-          if (String(operation.type || '').trim().toLowerCase() === 'delete') {
-            await removeUploadFileFromPlayer(uploadPath, mediaDir);
-          } else {
-            await pushUploadFileToPlayer(uploadPath, mediaDir);
-          }
+      for (let i = 0; i < desiredOperations.length; i += 1) {
+        const operation = desiredOperations[i] || {};
+        const uploadPath = String(operation.uploadPath || '').trim();
+        if (!uploadPath) {
+          continue;
         }
 
-        for (let i = 0; i < currentUploadPaths.length; i += 1) {
-          const uploadPath = String(currentUploadPaths[i] || '').trim();
-          if (!uploadPath || desiredUploadPaths.has(uploadPath)) {
-            continue;
-          }
-
+        if (String(operation.type || '').trim().toLowerCase() === 'delete') {
           await removeUploadFileFromPlayer(uploadPath, mediaDir);
+        } else {
+          await pushUploadFileToPlayer(uploadPath, mediaDir);
         }
       }
-    });
+
+      for (let i = 0; i < currentUploadPaths.length; i += 1) {
+        const uploadPath = String(currentUploadPaths[i] || '').trim();
+        if (!uploadPath || desiredUploadPaths.has(uploadPath)) {
+          continue;
+        }
+
+        await removeUploadFileFromPlayer(uploadPath, mediaDir);
+      }
+    }
   });
 }
 

src/web/lib/background-tasks/tasks-scheduled/onboarding-device-prune.js

@@ -0,0 +1,32 @@
+const TASK = {
+  key: 'onboarding-device-prune',
+  title: 'Onboarding device prune',
+  category: 'cleanup',
+  trigger: 'scheduled recurring task, hourly',
+  purpose: 'remove stale onboarding device bindings that have been idle for more than one minute.',
+  taskType: 'recurring-run',
+  intervalMs: 60 * 60 * 1000
+};
+
+function registerOnboardingDevicePruneTask(options) {
+  const backgroundTaskQueue = options && options.backgroundTaskQueue;
+  const pool = options && options.pool;
+  const common = options && options.common;
+
+  if (!backgroundTaskQueue || !pool || !common || typeof common.pruneStaleOnboardingDevices !== 'function') {
+    throw new Error('registerOnboardingDevicePruneTask requires the onboarding prune dependencies.');
+  }
+
+  backgroundTaskQueue.registerRecurringTask({
+    key: TASK.key,
+    title: TASK.title,
+    category: TASK.category,
+    intervalMs: TASK.intervalMs,
+    metadata: {},
+    run: async function () {
+      await common.pruneStaleOnboardingDevices(pool);
+    }
+  });
+}
+
+module.exports = { registerOnboardingDevicePruneTask };