Release v2.10.3

test/admin-client-commands.test.js

@@ -37,6 +37,9 @@ test('move client rebinding redirects the live player to the target screen', asy
         if (sql.includes('SELECT id, name, slug FROM d_screens WHERE slug = ?') && params && params[0] === 'target-screen') {
           return [[{ id: 27, name: 'Target Screen', slug: 'target-screen' }]];
         }
+        if (sql.includes('SELECT identifier, public_base_url FROM d_players WHERE public_base_url = ?')) {
+          return [[{ identifier: 'player-a', public_base_url: 'http://remote-player.example' }]];
+        }
         if (sql.includes('INSERT INTO d_onboarding_devices')) {
           return [{ affectedRows: 1 }];
         }
@@ -152,6 +155,61 @@ test('move client rebinding redirects the live player to the target screen', asy
   assert.equal(calls.some((entry) => entry.kind === 'forwardPlayerCommandToBaseUrl' && entry.baseUrl === 'http://remote-player.example'), true);
 });
 
+test('move client requires a registered player identity', async () => {
+  const { app, handlers } = createHandlers();
+
+  registerScreenCommandRoutes(app, {
+    pool: {
+      async query(sql) {
+        if (sql.includes('SELECT id, name, slug FROM d_screens WHERE slug = ?')) {
+          return [[{ id: 12, name: 'Source Screen', slug: 'source-screen' }]];
+        }
+        return [[]];
+      }
+    },
+    common: { fetchPlayerRegistrations: async () => [] },
+    forwardPlayerCommand: async () => ({ ok: true }),
+    forwardPlayerCommandToBaseUrl: async () => ({ ok: true }),
+    getScreenConnections: async () => ({ connections: [] }),
+    isClientNameAvailable: async () => true,
+    withClientNameReservation: async (_pool, _name, callback) => callback(),
+    broadcastDashboardState: async () => {},
+    requirePermission() {
+      return function (_req, _res, next) {
+        next();
+      };
+    }
+  });
+
+  const response = {
+    statusCode: 200,
+    body: null,
+    status(code) {
+      this.statusCode = code;
+      return this;
+    },
+    json(value) {
+      this.body = value;
+      return this;
+    }
+  };
+
+  await handlers['/clients/:slug/commands'][1]({
+    params: { slug: 'source-screen' },
+    body: {
+      command: 'moveclient',
+      deviceId: 'unregistered-device',
+      clientName: 'Lobby Client',
+      targetScreenSlug: 'target-screen',
+      playerBaseUrl: 'http://unregistered-player.example'
+    },
+    query: {}
+  }, response, () => {});
+
+  assert.equal(response.statusCode, 400);
+  assert.equal(response.body.error, 'Registered player identity is required');
+});
+
 test('screen control commands can target all screens', async () => {
   const calls = [];
   const { app, handlers } = createHandlers();